----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review114184 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 1164 - 1166) <https://reviews.apache.org/r/41769/#comment175008> This looks like a bug to me. I can't remember why we have `break` here in the first place. Could you please elaborate why do you think `break` is fine here? - Alexander Rukletsov On Dec. 31, 2015, 11:34 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41769/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 11:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Klaus Ma, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Made allocator traverse all roles for quota allocation. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 7f900c4e024485704d79e57ae22407557598fe6c > > Diff: https://reviews.apache.org/r/41769/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
