> On 一月 13, 2016, 11:41 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1164-1166 > > <https://reviews.apache.org/r/41769/diff/2/?file=1180221#file1180221line1164> > > > > This looks like a bug to me. I can't remember why we have `break` here > > in the first place. Could you please elaborate why do you think `break` is > > fine here?
It is a bit tricky here so I add some comments here even though I prefer we use `continue` here. The reason that it is OK to use `break` is because all of the quota roles are sorted based on starvation, if the roles in quota role sorter is satisfied, we can assume that all roles behind current satisfied role is also satisfied, that's why `break` here. Comments? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41769/#review114184 ----------------------------------------------------------- On 十二月 31, 2015, 11:34 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41769/ > ----------------------------------------------------------- > > (Updated 十二月 31, 2015, 11:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Klaus Ma, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Made allocator traverse all roles for quota allocation. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 7f900c4e024485704d79e57ae22407557598fe6c > > Diff: https://reviews.apache.org/r/41769/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
