-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41617/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 1:59 a.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-4231
https://issues.apache.org/jira/browse/MESOS-4231
Repository: mesos
Description
-------
Added a new category called whitespace/mesos-comments to capture missing,
leading, white-space in comments
Diffs (updated)
-----
support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1
support/mesos-style.py 5ee17593153df7815426918a1da6e25cb1188bca
Diff: https://reviews.apache.org/r/41617/diff/
Testing (updated)
-------
Ran the modified mesos-style.py on the existing code-base and got the following
errors:
src/authentication/cram_md5/authenticatee.hpp:60: Should have a space between
// and comment [whitespace/comments] [4]
src/authentication/cram_md5/authenticator.hpp:60: Should have a space between
// and comment [whitespace/comments] [4]
src/authorizer/local/authorizer.hpp:84: Should have a space between // and
comment [whitespace/comments] [4]
src/tests/containerizer/docker_containerizer_tests.cpp:978: Should have a
space between // and comment [whitespace/comments] [4]
3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp:90: At
least a single space is required between code and comments
[whitespace/comments] [2]
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp:127: Should have a
space between // and comment [whitespace/comments] [4]
Doesn't seem to give any false-positives. All the above errors do have a
missing leading white-space.
Tried a commit for the following patch:
diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp
index eb47b53..e579d20 100644
--- a/src/tests/slave_tests.cpp
+++ b/src/tests/slave_tests.cpp
@@ -2228,7 +2228,7 @@ TEST_F(SlaveTest, DiscoveryInfoAndPorts)
AWAIT_READY(launchTask);
- // Verify label key and value in slave state.json.
+ //Verify label key and value in slave state.json.
Future<process::http::Response> response =
process::http::get(slave.get(), "state.json");
And the git commit hook correctly failed it:
$ git commit -m "test"
Checking 1 files
src/tests/slave_tests.cpp:2231: Should have a space between // and comment
[whitespace/comments] [4]
Total errors found: 1
Thanks,
Avinash sridharan
