> On Jan. 14, 2016, 11:02 p.m., Michael Park wrote: > > support/cpplint.py, line 2641 > > <https://reviews.apache.org/r/41617/diff/3/?file=1197251#file1197251line2641> > > > > Sorry for the follow-up review after a `ShipIt`, but it looks like we > > missed something here. The comment says: `# Allow one space for new scopes, > > two spaces otherwise:`. The "new scope" part seems to be in this line: > > `Match(r'^\s*{ //', line)`. Can we just remove this now?
Ran the support/mesos-styles.py after this change and found zero errors. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41617/#review114602 ----------------------------------------------------------- On Jan. 15, 2016, 3:34 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41617/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 3:34 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4231 > https://issues.apache.org/jira/browse/MESOS-4231 > > > Repository: mesos > > > Description > ------- > > Added a new category called whitespace/mesos-comments to capture missing, > leading, white-space in comments > > > Diffs > ----- > > support/cpplint.py 6890e27f92603b025e25e4db01decf351c33c9a1 > support/mesos-style.py 5ee17593153df7815426918a1da6e25cb1188bca > > Diff: https://reviews.apache.org/r/41617/diff/ > > > Testing > ------- > > Tried a commit for the following patch: > diff --git a/src/tests/slave_tests.cpp b/src/tests/slave_tests.cpp > index eb47b53..e579d20 100644 > --- a/src/tests/slave_tests.cpp > +++ b/src/tests/slave_tests.cpp > @@ -2228,7 +2228,7 @@ TEST_F(SlaveTest, DiscoveryInfoAndPorts) > > AWAIT_READY(launchTask); > > - // Verify label key and value in slave state.json. > + //Verify label key and value in slave state.json. > Future<process::http::Response> response = > process::http::get(slave.get(), "state.json"); > > And the git commit hook correctly failed it: > $ git commit -m "test" > Checking 1 files > src/tests/slave_tests.cpp:2231: Should have a space between // and comment > [whitespace/comments] [4] > Total errors found: 1 > > > Thanks, > > Avinash sridharan > >
