> On Jan. 13, 2016, 6:59 p.m., Till Toenshoff wrote: > > src/tests/environment.cpp, lines 315-329 > > <https://reviews.apache.org/r/42197/diff/1/?file=1194614#file1194614line315> > > > > Why would we not show this warning to users on e.g. OSX? > > > > Right now I would assume that it makes sense to show this for all > > platforms that dont run the tests, just like we do e.g. for the below > > netcat stuff. Or am I missing something?
Perf is only available on Linux. But yes, it makes sense to inform the users of other platforms why these tests have been disabled, like `CfsFilter` or `DockerFilter`. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114238 ----------------------------------------------------------- On Jan. 13, 2016, 4:23 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42197/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 4:23 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-3082 > https://issues.apache.org/jira/browse/MESOS-3082 > > > Repository: mesos > > > Description > ------- > > Virtual machines may not always support 'CPU performance counters'. Tests > trying to collect to 'cycle' value of 'perf' will fail under these > circumstances. This will be avoided by disabling these tests if 'perf' > hardware > events are not available. > > > Diffs > ----- > > src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 > > Diff: https://reviews.apache.org/r/42197/diff/ > > > Testing > ------- > > `sudo ./bin/mesos-tests.sh > --gtest_filter="*ROOT_CGROUPS_Perf:*ROOT_CGROUPS_Sample:*ROOT_CGROUPS_UserCgroup:*CGROUPS_ROOT_PerfRollForward:*ROOT_Sample"` > in a VM without 'CPU performance counters'. This doesn't run any tests, as > expected. > > > Thanks, > > Jan Schlicht > >
