----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42197/#review114544 -----------------------------------------------------------
Ship it! LGTM, tested under scenarios 1), 2), and 3). *Please wait for a reviewer testing scenario 4)* (though it appears to make sense from my reading of the docs). - Benjamin Bannier On Jan. 14, 2016, 4:28 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42197/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 4:28 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-3082 > https://issues.apache.org/jira/browse/MESOS-3082 > > > Repository: mesos > > > Description > ------- > > Virtual machines may not always support 'CPU performance counters'. Tests > trying to collect to 'cycle' value of 'perf' will fail under these > circumstances. This will be avoided by disabling these tests if 'perf' > hardware > events are not available. > > > Diffs > ----- > > src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 > > Diff: https://reviews.apache.org/r/42197/diff/ > > > Testing > ------- > > Running `sudo ./bin/mesos-tests.sh > --gtest_filter="*ROOT_CGROUPS_Perf:*ROOT_CGROUPS_Sample:*ROOT_CGROUPS_UserCgroup:*CGROUPS_ROOT_PerfRollForward:*ROOT_Sample"` > > 1) In a Linux VM without 'CPU performance counters': This doesn't run the > tests and shows an error message that 'cycles' is not available, as expected > 2) In a Linux VM without 'perf': This doesn't run the tests and shows an > error message that 'perf' is not installed, as expected > 3) On OSX: This doesn't run the tests and shows an error message that 'perf' > is not available, as expected > 4) NOT TESTED YET!!! On native Linux (i.e. with 'CPU performance counters'): > This runs the tests. > > > Thanks, > > Jan Schlicht > >
