-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42098/#review114581
-----------------------------------------------------------



src/tests/containerizer/isolator_tests.cpp (line 845)
<https://reviews.apache.org/r/42098/#comment175416>

    Nit: >>



src/tests/containerizer/isolator_tests.cpp (lines 917 - 918)
<https://reviews.apache.org/r/42098/#comment175420>

    Add a `EXPECT_LE(1, pids.size())` here?
    (Right now, a string like " " would pass the check.)
    
    Maybe along with a comment like:
    // These are pids for the launcher, command executor, `sh`, and the sleep.



src/tests/containerizer/isolator_tests.cpp (lines 922 - 925)
<https://reviews.apache.org/r/42098/#comment175447>

    This isn't necessary.


- Joseph Wu


On Jan. 13, 2016, 6:42 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42098/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:42 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test-case for CgroupsNetClsIsolatorProcess.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
> 
> Diff: https://reviews.apache.org/r/42098/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Reply via email to