----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42098/#review115065 -----------------------------------------------------------
Ship it! src/tests/containerizer/isolator_tests.cpp (line 834) <https://reviews.apache.org/r/42098/#comment175915> 2 lines apart please. src/tests/containerizer/isolator_tests.cpp (line 884) <https://reviews.apache.org/r/42098/#comment175916> This is not needed. src/tests/containerizer/isolator_tests.cpp (lines 887 - 890) <https://reviews.apache.org/r/42098/#comment175917> You should put expection before 'driver.launchTasks'. Otherwise, you might get mock unsatisfied error. src/tests/containerizer/isolator_tests.cpp (lines 911 - 914) <https://reviews.apache.org/r/42098/#comment175918> I think you can use cgroups::processes here (see src/linux/cgroups.hpp) - Jie Yu On Jan. 14, 2016, 11:29 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42098/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 11:29 p.m.) > > > Review request for mesos, Jie Yu and Joseph Wu. > > > Bugs: MESOS-4262 > https://issues.apache.org/jira/browse/MESOS-4262 > > > Repository: mesos > > > Description > ------- > > Added unit test-case for CgroupsNetClsIsolatorProcess. > > > Diffs > ----- > > src/tests/containerizer/isolator_tests.cpp > 91178b69ccbf5b6cbf64421e5602e6d554fc34ca > > Diff: https://reviews.apache.org/r/42098/diff/ > > > Testing > ------- > > Enabled net_cls cgroup on ubuntu 14.04 and ran make check. > > > Thanks, > > Avinash sridharan > >
