> On Jan. 14, 2016, 11:05 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp, lines 17-33 > > <https://reviews.apache.org/r/42047/diff/3/?file=1189508#file1189508line17> > > > > No need for all the headers here.
Ok, will move it to the next commit. > On Jan. 14, 2016, 11:05 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 38-43 > > <https://reviews.apache.org/r/42047/diff/3/?file=1189507#file1189507line38> > > > > I prefer to use 70 char width if possible. But up to you. I have been using 80 till now. It shouldn't cause any stylistic diversity right ? - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42047/#review114588 ----------------------------------------------------------- On Jan. 12, 2016, 6:26 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42047/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 6:26 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4262 > https://issues.apache.org/jira/browse/MESOS-4262 > > > Repository: mesos > > > Description > ------- > > Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to > isolate a mesos container using the net_cls cgroup subsystem. > > > Diffs > ----- > > src/CMakeLists.txt 81afdc6c3e9b062efb181b2f92a9185bdd4acfb1 > src/Makefile.am 865926c5b46e42c5e29d3645a700c4ad20c1f11d > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42047/diff/ > > > Testing > ------- > > > Thanks, > > Avinash sridharan > >
