----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41333/#review114640 -----------------------------------------------------------
Ship it! Nice and simple :) include/mesos/resources.hpp (line 174) <https://reviews.apache.org/r/41333/#comment175499> You should briefly define usage slack here. Suggestion: s/revocable/, revocable resources that are allocated but under-utilized/ Ditto below. - Joseph Wu On Jan. 7, 2016, 10:03 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41333/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 10:03 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-4146 > https://issues.apache.org/jira/browse/MESOS-4146 > > > Repository: mesos > > > Description > ------- > > Added helper functions to filter usage slack resources. This helper function > will be used to validate if the task is using usage slack resource or not so > as to make sure that one task or executor can only use same kind of resources. > > > Diffs > ----- > > include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa > include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc > > Diff: https://reviews.apache.org/r/41333/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
