----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review114683 -----------------------------------------------------------
Ship it! You fix these last couple issues; Let me wrap up reviewing the tests and then we can commit these. src/master/allocator/mesos/hierarchical.cpp (line 1044) <https://reviews.apache.org/r/41597/#comment175548> I'm falling out of love with `updatingActiveRole`, because it makes it sound like there's only 1 active role. And `updatingAnActiveRole` is too many words. How about `impactsShares` or `rebalance` or `instantAllocation`? src/master/allocator/mesos/hierarchical.cpp (line 1050) <https://reviews.apache.org/r/41597/#comment175546> Since WeightInfo.role is optional, you should `CHECK_SOME()` it, or at least do an `if()` check. - Adam B On Jan. 12, 2016, 1:34 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41597/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 1:34 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-3943 > https://issues.apache.org/jira/browse/MESOS-3943 > > > Repository: mesos > > > Description > ------- > > Add the interface in allocator to support updating weight > at runtime, and the allocator is invoked to allocate the > resources based on the updated weights later. > > > Diffs > ----- > > include/mesos/master/allocator.hpp fcebcab71c50a725ca4e635c03c29eed2a406bc3 > include/mesos/mesos.proto 74e9d00d6826adfb7fd2433c3deced6d2ca51e98 > include/mesos/v1/mesos.proto 879107d842fd0d008b93fa10db7da8572640ea43 > src/master/allocator/mesos/allocator.hpp > 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 > src/master/allocator/mesos/hierarchical.hpp > 86ea5a402ed67f8f22f11d5730147cd907d66a08 > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/master/allocator/sorter/drf/sorter.hpp > 050896e8b12cd4097ccd137d5284d6b39b0f06ab > src/master/allocator/sorter/drf/sorter.cpp > 3a442f121f3a1505513877a5c78458a4b8d0a824 > src/master/allocator/sorter/sorter.hpp > 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 > src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef > > Diff: https://reviews.apache.org/r/41597/diff/ > > > Testing > ------- > > Make & Make check successfully! > > Test case: https://reviews.apache.org/r/41672/ > > > Thanks, > > Yongqiao Wang > >
