----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114762 -----------------------------------------------------------
src/tests/hook_tests.cpp (line 389) <https://reviews.apache.org/r/42241/#comment175618> If hookFuture never becomes ready that this blocks forever right? AWAIT_READY has a timeout built in, and we will want to also make sure we don't hang forever. Also do we have a logically expected time the hook future should be ready? Can we just advance once and then AWAIT? - Timothy Chen On Jan. 15, 2016, 6:20 p.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42241/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 6:20 p.m.) > > > Review request for mesos, Alexander Rukletsov and Timothy Chen. > > > Bugs: MESOS-4174 > https://issues.apache.org/jira/browse/MESOS-4174 > > > Repository: mesos > > > Description > ------- > > Add Clock::advance to fasten the speed of executor to be shutdown. > > > Diffs > ----- > > src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f > > Diff: https://reviews.apache.org/r/42241/diff/ > > > Testing > ------- > > Before > HookTest.VerifySlaveLaunchExecutorHook (5061 ms) > > After > HookTest.VerifySlaveLaunchExecutorHook (132 ms) > > > Thanks, > > Jian Qiu > >
