> On 一月 18, 2016, 11:49 a.m., Alexander Rukletsov wrote: > > src/tests/hook_tests.cpp, lines 396-399 > > <https://reviews.apache.org/r/42241/diff/2/?file=1199560#file1199560line396> > > > > Why do you need a loop here? Isn't it enought to advance once and then > > settle?
Right...there is no need to loop. Thanks for reminding! - Jian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114994 ----------------------------------------------------------- On 一月 18, 2016, 4:03 p.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42241/ > ----------------------------------------------------------- > > (Updated 一月 18, 2016, 4:03 p.m.) > > > Review request for mesos, Alexander Rukletsov and Timothy Chen. > > > Bugs: MESOS-4174 > https://issues.apache.org/jira/browse/MESOS-4174 > > > Repository: mesos > > > Description > ------- > > Speed up HookTest.VerifySlaveLaunchExecutorHook. > > > Diffs > ----- > > src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 > > Diff: https://reviews.apache.org/r/42241/diff/ > > > Testing > ------- > > Before > HookTest.VerifySlaveLaunchExecutorHook (5061 ms) > > After > HookTest.VerifySlaveLaunchExecutorHook (132 ms) > > > Thanks, > > Jian Qiu > >
