> On Jan. 13, 2016, 9:11 p.m., Timothy Chen wrote: > > src/uri/schemes/http.hpp, line 54 > > <https://reviews.apache.org/r/42236/diff/1/?file=1195238#file1195238line54> > > > > Should we provide the default port for https here?
Nope. Tools (e.g., curl) will figure out the default. I don't want to duplicate the logics here. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42236/#review114278 ----------------------------------------------------------- On Jan. 13, 2016, 6:22 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42236/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 6:22 a.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > ------- > > Added a utility function to create https URI. > > > Diffs > ----- > > src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf > > Diff: https://reviews.apache.org/r/42236/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
