> On Jan. 13, 2016, 7:05 p.m., Gilbert Song wrote:
> > LGTM! Just consider whether or not we should put it as `https.hpp` under 
> > `schemes` directory.

I prefer not. https is http + ssl. Also, they might share some functions in the 
future.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/#review114257
-----------------------------------------------------------


On Jan. 13, 2016, 6:22 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42236/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 6:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
>     https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a utility function to create https URI.
> 
> 
> Diffs
> -----
> 
>   src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 
> 
> Diff: https://reviews.apache.org/r/42236/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to