-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42415/#review114980
-----------------------------------------------------------



include/mesos/mesos.proto (line 241)
<https://reviews.apache.org/r/42415/#comment175823>

    This is pretty useless as it does not allow multiple roles. We do need a 
field `Repeated string roles` here like is written explicitly in the design doc.



include/mesos/v1/mesos.proto (line 241)
<https://reviews.apache.org/r/42415/#comment175824>

    This is pretty useless as it does not allow multiple roles. We do need a 
field `Repeated string roles` here like is written explicitly in the design doc.


- Benjamin Bannier


On Jan. 17, 2016, 5:32 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42415/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Bugs: MESOS-4363
>     https://issues.apache.org/jira/browse/MESOS-4363
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a roles field to FrameworkInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
>   include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 
> 
> Diff: https://reviews.apache.org/r/42415/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.5)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to