> On Jan. 18, 2016, 6:34 p.m., Benjamin Bannier wrote: > > include/mesos/mesos.proto, line 241 > > <https://reviews.apache.org/r/42415/diff/1/?file=1199455#file1199455line241> > > > > This is pretty useless as it does not allow multiple roles. We do need > > a field `Repeated string roles` here like is written explicitly in the > > design doc.
My bad, sorry about that. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review114980 ----------------------------------------------------------- On Jan. 19, 2016, 8:25 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42415/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 8:25 a.m.) > > > Review request for mesos, Benjamin Bannier and Vinod Kone. > > > Bugs: MESOS-4363 > https://issues.apache.org/jira/browse/MESOS-4363 > > > Repository: mesos > > > Description > ------- > > Added a roles field to FrameworkInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b > include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd > > Diff: https://reviews.apache.org/r/42415/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.5) > > > Thanks, > > Qian Zhang > >
