-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41772/#review115249
-----------------------------------------------------------



include/mesos/resources.hpp (lines 277 - 278)
<https://reviews.apache.org/r/41772/#comment176176>

    Suggestion:
    
    Returns a Resources object with the same amount of each resource type as 
these Resources.  If the optional `RevocableInfo` is given, the resource's 
`revocable` field is set.  Otherwise, the resource's `revocable` field is 
cleared.



src/common/resources.cpp (lines 874 - 877)
<https://reviews.apache.org/r/41772/#comment176163>

    This is pretty much a copy of `Resources::reserved` now.  You can remove it.



src/common/resources.cpp (line 880)
<https://reviews.apache.org/r/41772/#comment176167>

    It should be fine to just name this `flatten`.
    
    You should also consider changing the parameter type from 
`RevocableInfo::Type` to just `RevocableInfo`.  Supplying the whole 
`RevocableInfo` will save us another tweak to the helpers if we change the 
revocable protobufs again.


- Joseph Wu


On Jan. 15, 2016, 8:23 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41772/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 8:23 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, and Klaus Ma.
> 
> 
> Bugs: MESOS-4267
>     https://issues.apache.org/jira/browse/MESOS-4267
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function to flatten resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
>   include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
>   src/common/resources.cpp 575d6651185d8431f01d589f4afc255cb751181a 
>   src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666 
>   src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 
> 
> Diff: https://reviews.apache.org/r/41772/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="ResourcesOperationTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to