----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review115279 -----------------------------------------------------------
Is there some reason why you've split up these reviews into three pieces? (42113 and 42194) See below for my confusion: src/master/allocator/mesos/hierarchical.cpp (line 676) <https://reviews.apache.org/r/41791/#comment176234> I see several places where you overwrite changes from this review in the subsequent two. Did you mean to have three reviews for the changes to `::updateAllocation`, `::updateAvailable`, and `::recoverResources`? - Joseph Wu On Jan. 14, 2016, 4:44 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41791/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 4:44 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Update allocation slack resources if reserve some > new stateless reserved resources. For such case, > the allocation slack resources will be increased. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > d541bfa3f4190865c65d35c9d1ffdb8a3f194056 > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/41791/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
