> On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail
Thanks. I'll have a look. We will probably need to add support for "create network" in order to be able to test the created network. > On Jan. 19, 2016, 11:29 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1469 > > <https://reviews.apache.org/r/42516/diff/1/?file=1201987#file1201987line1469> > > > > What about name it as OVERLAY? We choose USER because it is defined by Docker as "user defined network" and can be either overlay or local bridge. You can see it here: https://docs.docker.com/engine/userguide/networking/dockernetworks/#user-defined-networks - Ezra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115278 ----------------------------------------------------------- On Jan. 19, 2016, 6:53 p.m., Ezra Silvera wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42516/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 6:53 p.m.) > > > Review request for mesos and TimothyIL TimothyIL. > > > Bugs: MESOS-4369 > https://issues.apache.org/jira/browse/MESOS-4369 > > > Repository: mesos > > > Description > ------- > > Since docker 1.9, Docker now supports user-defined networks (both local and > overlays). The user can then create containers that need to be attached to > these networks (e.g., docker run --net=my-network > In order to support user-defined network we need to make 2 changes: > 1a) Add a new network type in mesos.proto so that frameworks will be able to > pass this network type > 1b) Add a field to add the actual network name. Till now this was not needed > as users could not define their i own names. > 2) Change the executer so it supports processing port mapping also for > user-define network (instead of just for legacy bridge) > > Note that using the new user-defined network (both local and overlay) is > considered the prefered Docker networking option. > > Signed-off-by: Ezra Silvera <e...@il.ibm.com> > > > Diffs > ----- > > include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b > include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd > src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e > > Diff: https://reviews.apache.org/r/42516/diff/ > > > Testing > ------- > > Using Swarm running on Mesos create a network with "docker network create > --driver=bridge myNetwork" and then create a container on that network: > "docker run --net=myNetwork...." > > > Thanks, > > Ezra Silvera > >
