-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41790/#review115398
-----------------------------------------------------------



src/tests/dynamic_weights_tests.cpp (line 120)
<https://reviews.apache.org/r/41790/#comment176398>

    Please put the open brace `{` on a new line.



src/tests/dynamic_weights_tests.cpp (line 400)
<https://reviews.apache.org/r/41790/#comment176399>

    s/role/roles/


- Adam B


On Jan. 20, 2016, 1:14 a.m., Yongqiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41790/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 1:14 a.m.)
> 
> 
> Review request for mesos, Adam B, Neil Conway, and Qian Zhang.
> 
> 
> Bugs: MESOS-4200
>     https://issues.apache.org/jira/browse/MESOS-4200
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add tests for /weights endpoint.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 4fabe600d4ba38c95a777d622b0b675dd5811a53 
>   src/tests/dynamic_weights_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41790/diff/
> 
> 
> Testing
> -------
> 
> Make and Make check successfully!
> 
> ./src/mesos-tests --gtest_filter=DynamicWeightsTest.*
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from DynamicWeightsTest
> [ RUN      ] DynamicWeightsTest.PutInvalidRequest
> [       OK ] DynamicWeightsTest.PutInvalidRequest (102 ms)
> [ RUN      ] DynamicWeightsTest.ZeroWeight
> [       OK ] DynamicWeightsTest.ZeroWeight (38 ms)
> [ RUN      ] DynamicWeightsTest.NegativeWeight
> [       OK ] DynamicWeightsTest.NegativeWeight (38 ms)
> [ RUN      ] DynamicWeightsTest.MissingRole
> [       OK ] DynamicWeightsTest.MissingRole (43 ms)
> [ RUN      ] DynamicWeightsTest.UnknownRole
> [       OK ] DynamicWeightsTest.UnknownRole (36 ms)
> [ RUN      ] DynamicWeightsTest.UpdateWeightsWithExplictRoles
> [       OK ] DynamicWeightsTest.UpdateWeightsWithExplictRoles (44 ms)
> [ RUN      ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles
> [       OK ] DynamicWeightsTest.UpdateWeightsWithImplicitRoles (52 ms)
> [ RUN      ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest
> [       OK ] DynamicWeightsTest.UnauthenticatedUpdateWeightRequest (40 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.AuthorizedWeightUpdateRequest (32 ms)
> [ RUN      ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal
> [       OK ] DynamicWeightsTest.AuthorizedUpdateWeightRequestWithoutPrincipal 
> (37 ms)
> [ RUN      ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest
> [       OK ] DynamicWeightsTest.UnauthorizedWeightUpdateRequest (30 ms)
> [----------] 11 tests from DynamicWeightsTest (492 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (503 ms total)
> [  PASSED  ] 11 tests.
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Reply via email to