-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42368/
-----------------------------------------------------------
(Updated Jan. 20, 2016, 6:59 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Vinod Kone.
Changes
-------
Updated comments.
Summary (updated)
-----------------
Added reservation endpoint test without authentication.
Bugs: MESOS-4195
https://issues.apache.org/jira/browse/MESOS-4195
Repository: mesos
Description (updated)
-------
Added reservation endpoint test without authentication.
Currently, dynamic reservation endpoints will not work when HTTP authentication
is not set. Currently, the authentication code will always return `None()` as
the principal when authentication is disabled. Furthermore, the
`ReservationInfo.principal` field is being migrated to `optional`, so dynamic
reservations without a principal are invalidated by the master. This test
checks that these endpoints will fail as expected when HTTP authentication is
disabled.
Diffs (updated)
-----
src/tests/reservation_endpoints_tests.cpp
b8edd6fafedd4c2221a8d19c1ebc71254071a8c7
Diff: https://reviews.apache.org/r/42368/diff/
Testing
-------
A new test, `ReservationEndpointsTest.ReserveAndUnreserveNoAuthentication`, was
added, and make check was used to test. The new test was also run with
`--gtest_repeat=1000 --gtest_break_on_failure=1`.
Thanks,
Greg Mann
