----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/#review115534 -----------------------------------------------------------
src/slave/slave.cpp (lines 1384 - 1388) <https://reviews.apache.org/r/41855/#comment176509> You probably don't need this additional tracking. It looks like you're inserting the executor eviction logic inside the code path for running executors. i.e.: `::runTask` -> (evict executors logic) -> `::_runTask` -> `::launchExecutor` All of these things happen inside the Agent actor and the eviction logic can be mostly synchronous. So you can just pass the executor-to-be-launched around. (The less state you save == less error prone the function is.) - Joseph Wu On Jan. 9, 2016, 1:38 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41855/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 1:38 a.m.) > > > Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris > Van Remoortere, Joseph Wu, and Jian Qiu. > > > Bugs: MESOS-3892 > https://issues.apache.org/jira/browse/MESOS-3892 > > > Repository: mesos > > > Description > ------- > > Trace the executor that are not launched; after launching, it's removed from > pendingExecutor list. > > > Diffs > ----- > > src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c > src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f > > Diff: https://reviews.apache.org/r/41855/diff/ > > > Testing > ------- > > > Thanks, > > Klaus Ma > >
