-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42559/#review115539
-----------------------------------------------------------


There maybe risk if we want to catch up with 0.27.0 for this.


src/master/allocator/mesos/hierarchical.cpp (lines 1311 - 1314)
<https://reviews.apache.org/r/42559/#comment176519>

    I would suggest adding a new revocable type here, according to the design 
of MESOS-1607, this API will set resources as `USAGE SLACK` which means 
`resources allocated but under-utilized`, but here giving `USAGE SLACK` another 
meaning: resources beyond quota which does not fit into the `USAGE SLACK` well.



src/master/allocator/mesos/hierarchical.cpp (line 1313)
<https://reviews.apache.org/r/42559/#comment176518>

    I would suggest adding a new revocable type here, according to the design 
of MESOS-1607, this API will set resources as `USAGE SLACK` which means 
`resources allocated but under-utilized`, but here giving `USAGE SLACK` another 
meaning: resources beyond quota which does not fit into the `USAGE SLACK` well.



src/master/allocator/mesos/hierarchical.cpp (line 1329)
<https://reviews.apache.org/r/42559/#comment176516>

    The filter will not work after you set the resources as revocable.



src/tests/hierarchical_allocator_tests.cpp (line 1621)
<https://reviews.apache.org/r/42559/#comment176517>

    You may encounter some problem if you add some static reserved resources.


- Guangya Liu


On 一月 20, 2016, 5:01 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42559/
> -----------------------------------------------------------
> 
> (Updated 一月 20, 2016, 5:01 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, Joseph Wu, 
> and Qian Zhang.
> 
> 
> Bugs: MESOS-4441
>     https://issues.apache.org/jira/browse/MESOS-4441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/quota.md 1a6d2f07fb74d168a7eb30764ab9ff80cea5e3b6 
>   src/master/allocator/mesos/hierarchical.cpp 
> e32ee4aa3ed9793bb5a99233e699e5cc2bdd796b 
>   src/tests/hierarchical_allocator_tests.cpp 
> 953712149bd951789beb29c72779c4ac65aa48dc 
> 
> Diff: https://reviews.apache.org/r/42559/diff/
> 
> 
> Testing
> -------
> 
> On Mac OS 10.10.4:
> 
> `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh 
> --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle`
> `make check`
> 
> Updated `HierarchicalAllocatorTest.DRFWithQuota` succeeds with the change and 
> fails without.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to