----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115605 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 1342 - 1344) <https://reviews.apache.org/r/42559/#comment176596> So here we offer `offerableResources` to framework and mark `resources` as allocated resource of the slave. But for a framework in a quota'ed role, `offerableResources` and `resources` may be different, the former is revocable and the later is non-revocable, so later when `recoverResources()` is called (e.g., the offer is declined by framework), we will subtract offered resources from allocated resources (`slaves[slaveId].allocated -= resources;`), I think the subtraction will not work as we expect since the offered resources are revocable but allocated resources are non-revocable. - Qian Zhang On Jan. 21, 2016, 1:01 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42559/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 1:01 a.m.) > > > Review request for mesos, Bernd Mathiske, Joris Van Remoortere, Joseph Wu, > and Qian Zhang. > > > Bugs: MESOS-4441 > https://issues.apache.org/jira/browse/MESOS-4441 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/quota.md 1a6d2f07fb74d168a7eb30764ab9ff80cea5e3b6 > src/master/allocator/mesos/hierarchical.cpp > e32ee4aa3ed9793bb5a99233e699e5cc2bdd796b > src/tests/hierarchical_allocator_tests.cpp > 953712149bd951789beb29c72779c4ac65aa48dc > > Diff: https://reviews.apache.org/r/42559/diff/ > > > Testing > ------- > > On Mac OS 10.10.4: > > `GTEST_FILTER="HierarchicalAllocatorTest.*" ./bin/mesos-tests.sh > --gtest_repeat=100 --gtest_break_on_failure --gtest_shuffle` > `make check` > > Updated `HierarchicalAllocatorTest.DRFWithQuota` succeeds with the change and > fails without. > > > Thanks, > > Alexander Rukletsov > >
