----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review115685 -----------------------------------------------------------
I was expecting a `mesos-slave` executable, but I don't see any `add_executable` (or something that actually generates an executable) in this patch. Was that intentional? src/slave/CMakeLists.txt (lines 17 - 19) <https://reviews.apache.org/r/41092/#comment176709> Clean this up? src/slave/CMakeLists.txt (line 42) <https://reviews.apache.org/r/41092/#comment176701> Nit: Pre-commit hooks complain about this line. (Delete it) - Joseph Wu On Jan. 21, 2016, 8:58 a.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41092/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 8:58 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Added CMake file for agent executable build. > > > Diffs > ----- > > src/slave/CMakeLists.txt PRE-CREATION > src/slave/cmake/SlaveConfigure.cmake > fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41092/diff/ > > > Testing > ------- > > Tested on Ubuntu and OSX. > > > Thanks, > > Diana Arroyo > >
