----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review115945 -----------------------------------------------------------
Patch looks great! Reviews applied: [42530, 42362] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 22, 2016, 5:03 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42362/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2016, 5:03 p.m.) > > > Review request for mesos, Alexander Rukletsov, Michael Park, and Neil Conway. > > > Bugs: MESOS-4395 > https://issues.apache.org/jira/browse/MESOS-4395 > > > Repository: mesos > > > Description > ------- > > Added persistent volume endpoint tests with HTTP authentication disabled, > both with and without authorization enabled. > > The persistent volume endpoint tests allow volume creation and destruction > without authorization and without a principal; this patch introduces test > cases for this scenario: > `PersistentVolumeEndpointsTest.NoAuthenticationNoAuthorization` and > `PersistentVolumeEndpointsTest.NoAuthenticationWithAuthorization`. NOTE: due > to the current behavior of the HTTP authentication code, when HTTP > authentication is disabled, the endpoint callbacks always receive a principal > of `None()`, which means that authorization cannot be properly used when HTTP > authentication is disabled. > > > Diffs > ----- > > src/tests/persistent_volume_endpoints_tests.cpp > 22e18758ee91a649486725473d9e50fae9d43b01 > > Diff: https://reviews.apache.org/r/42362/diff/ > > > Testing > ------- > > A new test, `PersistentVolumeEndpointsTest.NoAuthorization`, was added to the > persistent volume endpoint tests. > > `make check` was used to test, and the new test was run with > `--gtest_repeat=1000 -gtest_break_on_failure=1`. > > > Thanks, > > Greg Mann > >
