----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42362/#review116757 -----------------------------------------------------------
Fix it, then Ship it! src/tests/persistent_volume_endpoints_tests.cpp (line 1085) <https://reviews.apache.org/r/42362/#comment177832> I think this comment should say something about disabling authn rather then creating a master. Moreover, though it's not the way it's done in legacy tests, I would omit a self explanatory comment about creating a master here. src/tests/persistent_volume_endpoints_tests.cpp (line 1087) <https://reviews.apache.org/r/42362/#comment177833> Does it make sense to add `masterFlags.credentials = None();`? src/tests/persistent_volume_endpoints_tests.cpp (line 1094) <https://reviews.apache.org/r/42362/#comment177834> s/a slave/an agent src/tests/persistent_volume_endpoints_tests.cpp (line 1099) <https://reviews.apache.org/r/42362/#comment177835> s/slaveId/agentId and everywhere if you decide to abolish slavery in this test : ). src/tests/persistent_volume_endpoints_tests.cpp (line 1108) <https://reviews.apache.org/r/42362/#comment177836> Let's extract "role1" into a constant in the beginning of the test. src/tests/persistent_volume_endpoints_tests.cpp (line 1120) <https://reviews.apache.org/r/42362/#comment177837> To be 100% correct, you should `ASSERT_READY(slaveId);` before. - Alexander Rukletsov On Jan. 27, 2016, 11:04 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42362/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 11:04 p.m.) > > > Review request for mesos, Alexander Rukletsov, Kapil Arya, and Neil Conway. > > > Bugs: MESOS-4395 > https://issues.apache.org/jira/browse/MESOS-4395 > > > Repository: mesos > > > Description > ------- > > Added persistent volume endpoint tests with HTTP authentication disabled. > > The persistent volume endpoint tests allow volume creation and destruction > when HTTP authentication is disabled; this patch introduces a test for this > scenario: `PersistentVolumeEndpointsTest.NoAuthentication`. > > > Diffs > ----- > > src/tests/persistent_volume_endpoints_tests.cpp > 22e18758ee91a649486725473d9e50fae9d43b01 > > Diff: https://reviews.apache.org/r/42362/diff/ > > > Testing > ------- > > A new test, `PersistentVolumeEndpointsTest.NoAuthentication`, was added to > the persistent volume endpoint tests. > > `make check` was used to test, and the new test was run with > `--gtest_repeat=1000 -gtest_break_on_failure=1`. > > > Thanks, > > Greg Mann > >
