----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review116243 -----------------------------------------------------------
src/master/master.cpp (lines 1980 - 1983) <https://reviews.apache.org/r/42685/#comment177244> This should probably be replaced with `strings::join("'", frameworkInfo.roles())` which could be used directly when creating the `Error` below. src/master/master.cpp (lines 2250 - 2253) <https://reviews.apache.org/r/42685/#comment177245> Use `strings::join`, w/o introducing a named var. src/tests/role_tests.cpp (lines 97 - 98) <https://reviews.apache.org/r/42685/#comment177254> This constructor seems to be deprecated (even though it is used above). Instead you should be able to use MesosSchedulerDriver driver( &sched, frameworkInfo, master.get(), false); - Benjamin Bannier On Jan. 23, 2016, 1:47 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42685/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 1:47 p.m.) > > > Review request for mesos, Benjamin Bannier and Vinod Kone. > > > Bugs: MESOS-4364 > https://issues.apache.org/jira/browse/MESOS-4364 > > > Repository: mesos > > > Description > ------- > > Validated either role or roles in FrameworkInfo can be set, > but never both. > > > Diffs > ----- > > src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 > src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 > > Diff: https://reviews.apache.org/r/42685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
