> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, lines 1980-1983 > > <https://reviews.apache.org/r/42685/diff/1/?file=1218820#file1218820line1980> > > > > This should probably be replaced with `strings::join("'", > > frameworkInfo.roles())` which could be used directly when creating the > > `Error` below. > > Benjamin Bannier wrote: > I meant `strings::join(",", frameworkInfo.roles())` of course, sorry.
Agree and fixed, thanks Ben! > On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, lines 2250-2253 > > <https://reviews.apache.org/r/42685/diff/1/?file=1218820#file1218820line2250> > > > > Use `strings::join`, w/o introducing a named var. Agree and fixed, thanks Ben! > On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote: > > src/tests/role_tests.cpp, lines 97-98 > > <https://reviews.apache.org/r/42685/diff/1/?file=1218821#file1218821line97> > > > > This constructor seems to be deprecated (even though it is used above). > > Instead you should be able to use > > > > MesosSchedulerDriver driver( > > &sched, frameworkInfo, master.get(), false); Agree and fixed, thanks Ben! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review116243 ----------------------------------------------------------- On Jan. 27, 2016, 1:26 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42685/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 1:26 p.m.) > > > Review request for mesos, Benjamin Bannier and Vinod Kone. > > > Bugs: MESOS-4364 > https://issues.apache.org/jira/browse/MESOS-4364 > > > Repository: mesos > > > Description > ------- > > Validated either role or roles in FrameworkInfo can be set, > but never both. > > > Diffs > ----- > > src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > > Diff: https://reviews.apache.org/r/42685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
