----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42789/#review116417 -----------------------------------------------------------
Thanks for writing this, Kevin! I'm going to extend it to output the configuration flags documentation to disk. For this reason, I wonder if you could give the file a more generic name? support/endpoint-docs.cpp (line 91) <https://reviews.apache.org/r/42789/#comment177435> Perhaps use a more descriptive name for this typedef? support/endpoint-docs.cpp (line 102) <https://reviews.apache.org/r/42789/#comment177436> You can omit the `void` parameter here, and below. support/endpoint-docs.cpp (line 150) <https://reviews.apache.org/r/42789/#comment177442> s/standad/standard/ support/endpoint-docs.cpp (line 211) <https://reviews.apache.org/r/42789/#comment177471> Could use `foreach ( ... )` here, and below. - Greg Mann On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42789/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 7:41 a.m.) > > > Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > After building mesos from source, an executable called > mesos-endpoint-docs will be created in build/src. Invoke this executable > with the flag --dirname=../docs/endpoints to autogenerate documentation > for all endpoint strings and install it into the proper location. In a > subsequent commit we will add a link to this directory in home.md. > > > Diffs > ----- > > src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 > support/endpoint-docs.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/42789/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Klues > >
