----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review116466 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (line 288) <https://reviews.apache.org/r/39782/#comment177490> Nit-pick: Replace `Setting ... . Neither` with `This has an effect only for child processes launched after calling setPaths; neither`. - Benjamin Bannier On Jan. 26, 2016, 8:24 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39782/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 8:24 p.m.) > > > Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and > Till Toenshoff. > > > Bugs: MESOS-3725 > https://issues.apache.org/jira/browse/MESOS-3725 > > > Repository: mesos > > > Description > ------- > > Add a comment for os::libraries::setPaths. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6 > > Diff: https://reviews.apache.org/r/39782/diff/ > > > Testing > ------- > > No code changes. > > > Thanks, > > James Peach > >
