-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42184/#review116481
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/mesos.hpp (line 1511)
<https://reviews.apache.org/r/42184/#comment177497>

    why do you need a default?



src/tests/mesos.hpp (line 1532)
<https://reviews.apache.org/r/42184/#comment177498>

    why do you need a default?



src/tests/mesos.hpp (line 1582)
<https://reviews.apache.org/r/42184/#comment177499>

    ditto. why default?



src/tests/mesos.hpp (line 1600)
<https://reviews.apache.org/r/42184/#comment177500>

    why default?



src/tests/mesos.hpp (line 1638)
<https://reviews.apache.org/r/42184/#comment177501>

    ditto.



src/tests/mesos.hpp (line 1656)
<https://reviews.apache.org/r/42184/#comment177502>

    ditto.


- Vinod Kone


On Jan. 22, 2016, 8:17 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42184/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 8:17 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4425
>     https://issues.apache.org/jira/browse/MESOS-4425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces `FUTURE_HTTP_*` for filtering HTTP based events 
> similar to the already existing filters for Messages/Dispatch events. Also, 
> added `FUTURE_HTTP_CALL_*` for union based protobufs.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 3d9ebc6c9dc3cd1be02dc3771fbd847386907fac 
> 
> Diff: https://reviews.apache.org/r/42184/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to