----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review116776 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 1333 - 1335) <https://reviews.apache.org/r/40632/#comment177869> The result is un-stable here: if framework accept reserved resource come firstly, the others can not get those revocable resources; but if tenant framework come fristly, it will get revocable resources. It all depedent on sorter, and the offer maybe wrong in about cases. - Klaus Ma On Jan. 23, 2016, 11:18 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2016, 11:18 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 65c7e6b15c5308c0910667e1b12f39b21293a316 > src/tests/hierarchical_allocator_tests.cpp > b1cb955b7eb1213c7ba4a9c5181545bb49154f06 > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.*" > --verbose --gtest_repeat=100 --gtest_shuffle > > > Thanks, > > Guangya Liu > >
