----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review116971 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line 788) <https://reviews.apache.org/r/42794/#comment178045> Please end a period at the end of the sentence. - Kapil Arya On Jan. 29, 2016, 12:15 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42794/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2016, 12:15 p.m.) > > > Review request for mesos, Kapil Arya and Jan Schlicht. > > > Bugs: MESOS-3317 > https://issues.apache.org/jira/browse/MESOS-3317 > > > Repository: mesos > > > Description > ------- > > URL query string order is defined. > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 > 3rdparty/libprocess/src/tests/http_tests.cpp > 66d185e3fd8a165d8a98d3d2752e756f8de3499b > > Diff: https://reviews.apache.org/r/42794/diff/ > > > Testing > ------- > > The following test cases in http_test.cpp have been modified - > HTTPTest.QueryEncodeDecode to check generated query strings in URL to be > according alphabatic order. > URLTest.Stringification to check generated query strings in URL to be > according alphabatic order. > > > Thanks, > > Abhishek Dasgupta > >
