> On Jan. 28, 2016, 6:48 p.m., haosdent huang wrote:
> > src/launcher/executor.cpp, line 269
> > <https://reviews.apache.org/r/42539/diff/4/?file=1225128#file1225128line269>
> >
> >     I could understand we need TaskCommand to combine different things. But 
> > because the interface is `void launchTask(ExecutorDriver* driver, const 
> > TaskInfo& task)`. Ignore it and use the command line param to launchTaks 
> > looks a bit strange. Maybe we change to `void launchTask(ExecutorDriver* 
> > driver, const TaskCommand& task)`

Hi, haosdent. Thank you for the reviews above. I understand that the way we do 
it in command executor is a little hacky. but:
1. It may not be realistic to change the api interface at this moment. 
2. Even if we can change the interface, it is still hard to pass information 
from containerizer back to slave.
3. If you look at the logic table in `mesos/containerizer.hpp` comments, you 
can see for most of the case in command executor, we will still use the 
`CommandInfo` from `TaskInfo` directly if no image is specified /or `value` is 
specified. Only for the cases that we need image default config, the 
`--task_command` flag will be attached.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42539/#review116882
-----------------------------------------------------------


On Jan. 29, 2016, 2:15 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42539/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 2:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4004
>     https://issues.apache.org/jira/browse/MESOS-4004
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support image specified Entrypoint and Cmd.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 4b504dbb58823ce7675f1d2048dcc7a27c05663d 
> 
> Diff: https://reviews.apache.org/r/42539/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to