----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/#review117458 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 105) <https://reviews.apache.org/r/43081/#comment178647> s/executorLaunchCommand/command/ src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 156 - 157) <https://reviews.apache.org/r/43081/#comment178650> .. which will be used to launch the executor. src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 161) <https://reviews.apache.org/r/43081/#comment178651> Do you want to use contianer_config() here? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 165) <https://reviews.apache.org/r/43081/#comment178652> For command task case, src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 165 - 166) <https://reviews.apache.org/r/43081/#comment178653> if no need to change the launch command for the user task src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 172 - 175) <https://reviews.apache.org/r/43081/#comment178654> 1. If 'shell' is true, we will ignore Entrypoint and Cmd from the docker image (row 5-8). src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 176 - 178) <https://reviews.apache.org/r/43081/#comment178655> If 'shell' is false and 'value' is set, we will ignore the Entrypoint and Cmd from the docker image as well (row 3-4). src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 229 - 272) <https://reviews.apache.org/r/43081/#comment178658> OK, you pretty much duplicated the logics here below, right? Can we merge them? My suggestion earlier should allow you to merge them? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 233) <https://reviews.apache.org/r/43081/#comment178657> container_config() here? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 276) <https://reviews.apache.org/r/43081/#comment178656> return Error? - Jie Yu On Feb. 2, 2016, 5:18 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43081/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 5:18 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4004 > https://issues.apache.org/jira/browse/MESOS-4004 > > > Repository: mesos > > > Description > ------- > > Supported entrypoint and cmd in docker runtime isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 4b504dbb58823ce7675f1d2048dcc7a27c05663d > src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43081/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
