----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43081/#review117844 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/runtime.cpp (lines 262 - 263) <https://reviews.apache.org/r/43081/#comment179101> Hum, what if this is a command task? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 267) <https://reviews.apache.org/r/43081/#comment179102> Hum, this is problematic too because entrypoint itself can have multiple arguments, right? src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 293) <https://reviews.apache.org/r/43081/#comment179103> Hum, why this check? - Jie Yu On Feb. 3, 2016, 8:41 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43081/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 8:41 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4004 > https://issues.apache.org/jira/browse/MESOS-4004 > > > Repository: mesos > > > Description > ------- > > Supported entrypoint and cmd in docker runtime isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 4b504dbb58823ce7675f1d2048dcc7a27c05663d > src/slave/containerizer/mesos/isolators/docker/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/43081/diff/ > > > Testing > ------- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
