----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117534 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 74) <https://reviews.apache.org/r/42586/#comment178748> s/NetClsHandleMgr/NetClsHandleManager/ src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 83) <https://reviews.apache.org/r/42586/#comment178735> s/allocMajor/allocPrimary/ src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 91) <https://reviews.apache.org/r/42586/#comment178737> Two things: 1) Can you `s/_netClsHandles/used/`? 2) Can you just use bitset<0x10000> here? No need for the constant. - Jie Yu On Feb. 3, 2016, 12:43 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42586/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 12:43 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > This class will be responsible for keeping track of the free and allocated > net_cls handles. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > > Diff: https://reviews.apache.org/r/42586/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
