----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117633 -----------------------------------------------------------
Looks good. Some minor comments modulo Jie's earlier comments. src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 41) <https://reviews.apache.org/r/42586/#comment178878> Nit: Can you add a new line before the `TODO`? Similar reasoning as to my comment on r42587 earlier. src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 48) <https://reviews.apache.org/r/42586/#comment178875> Why do you need this default constructor? Also, are you sure the standard gurrantees that member values would be zero initialized? I thought that the default initialization happens only for `POD` types? src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp (line 53) <https://reviews.apache.org/r/42586/#comment178873> Can we make this constructor explicit to avoid implicit conversions? - Anand Mazumdar On Feb. 3, 2016, 6:44 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42586/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 6:44 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > ------- > > This class will be responsible for keeping track of the free and allocated > net_cls handles. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp > b4bc52114389d1c1efce2830f4292bd89bb0de7c > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > ddc1bf0939e5e8995e6f34fe7b8509b51704f63e > > Diff: https://reviews.apache.org/r/42586/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
