> On Feb. 2, 2016, 11:02 p.m., Vinod Kone wrote: > > src/tests/slave_recovery_tests.cpp, line 1046 > > <https://reviews.apache.org/r/42186/diff/4/?file=1222479#file1222479line1046> > > > > I think you should start the slave with fixed id like in the above > > test, to ensure the executor tries to connect to the right endpoint.
Fixed. I had not done so earlier since for recovery mode `cleanup`, the executor would be killed anyways. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42186/#review117513 ----------------------------------------------------------- On Feb. 3, 2016, 2:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42186/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 2:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4255 > https://issues.apache.org/jira/browse/MESOS-4255 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 > > Diff: https://reviews.apache.org/r/42186/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
