----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39781/#review117786 -----------------------------------------------------------
Fix it, then Ship it! Thanks James! There are two minor style nits left, will fix while committing but will leave them open for your information. Please close them once you skimmed over them :) src/tests/module_tests.cpp (line 66) <https://reviews.apache.org/r/39781/#comment179049> Thanks for this one :) src/tests/module_tests.cpp (lines 128 - 129) <https://reviews.apache.org/r/39781/#comment179050> The correct wrapping here would be: ``` library->set_file( path::join(libraryDirectory, os::libraries::expandName(libraryName))); ``` It is an argument continuation, hence we indent by 4 spaces. src/tests/module_tests.cpp (lines 160 - 161) <https://reviews.apache.org/r/39781/#comment179051> The correct wrapping here would be: ``` string libraryFile = path::join(libraryDirectory, os::libraries::expandName(libraryName)); ``` Note how we prefer to wrap at assignments if possible. Then given that this is not an argument wrapping, we now indent by 2 spaces. - Till Toenshoff On Jan. 27, 2016, 6:44 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39781/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 6:44 p.m.) > > > Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and > Till Toenshoff. > > > Bugs: MESOS-3725 > https://issues.apache.org/jira/browse/MESOS-3725 > > > Repository: mesos > > > Description > ------- > > Update ModuleTest to not assume dynamic dlopen search. > > > Diffs > ----- > > src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 > > Diff: https://reviews.apache.org/r/39781/diff/ > > > Testing > ------- > > make check > > > Thanks, > > James Peach > >
