-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43144/#review117806
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp (line 2202)
<https://reviews.apache.org/r/43144/#comment179070>

    blank line before.



3rdparty/libprocess/src/process.cpp (line 2211)
<https://reviews.apache.org/r/43144/#comment179069>

    Just `os::getenv("LIB...")` is OK.


- Klaus Ma


On Feb. 4, 2016, 4:57 a.m., Maged Michael wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43144/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 4:57 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added env var to set upper bound on number of worker threads.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 
> d8a74d7637d20c81f384e974e4fdeba22effb437 
> 
> Diff: https://reviews.apache.org/r/43144/diff/
> 
> 
> Testing
> -------
> 
> Invocations of mesos-master, mesos-slave, and mesos-tests with the 
> LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", 
> "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system.
> 
> The results were as expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were 
> created, respectively. The last 3 tests generated warnings, e.g., 
> "LIBPROCESS_MAX_WORKER_THREADS=abc is invalid".
> 
> 
> Thanks,
> 
> Maged Michael
> 
>

Reply via email to