----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117947 -----------------------------------------------------------
The document should also be updated `docs/configuration.md` by adding some explanation for this parameter. 3rdparty/libprocess/src/process.cpp (lines 2212 - 2213) <https://reviews.apache.org/r/43144/#comment179239> Why not Option<string> value = os::getenv("LIBPROCESS_MAX_WORKER_THREADS"); 3rdparty/libprocess/src/process.cpp (line 2220) <https://reviews.apache.org/r/43144/#comment179241> I think we should add some logs here if the `cpus` override the `max_cpus.get()`, the end user may be confused for such case: Why my env does not take effect? 3rdparty/libprocess/src/process.cpp (line 2222) <https://reviews.apache.org/r/43144/#comment179240> I think that warning message should also be enhanced that `"Ignoring invalid value " << value.get() << " for LIBPROCESS_MAX_WORKER_THREADS, using system defined value " << cpus;` - Guangya Liu On 二月 4, 2016, 7:55 p.m., Maged Michael wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43144/ > ----------------------------------------------------------- > > (Updated 二月 4, 2016, 7:55 p.m.) > > > Review request for mesos and Klaus Ma. > > > Bugs: MESOS-4353 > https://issues.apache.org/jira/browse/MESOS-4353 > > > Repository: mesos > > > Description > ------- > > Added env var to set upper bound on number of libprocess worker threads. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp d8a74d7 > > Diff: https://reviews.apache.org/r/43144/diff/ > > > Testing > ------- > > Passed make check on x86_64 Ubuntu 14.04. > > Invocations of mesos-master, mesos-slave, and mesos-tests with the > LIBPROCESS_MAX_WORKER_THREADS set to the values "1", "7", "9", "1000", "0", > "-1", and "abc" on a 4-core x86_64 Ubuntu 14.04 system. The results were as > expected. 1, 7, 8, 8, 8, 8, and 8 worker threads were created, respectively. > The last 3 tests generated warnings. > > > Thanks, > > Maged Michael > >
