----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117856 -----------------------------------------------------------
src/slave/containerizer/fetcher.cpp (lines 751 - 752) <https://reviews.apache.org/r/43177/#comment179108> Perhaps you should augment this comment with something like: ``` The libprocess port is explicitly removed because this will conflict with the already-running agent. ``` - Joseph Wu On Feb. 3, 2016, 9:47 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43177/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 9:47 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4585 > https://issues.apache.org/jira/browse/MESOS-4585 > > > Repository: mesos > > > Description > ------- > > Erased libprocess related env vars for mesos-fetcher. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > dbf968df4b219fbbafd59d5560492b7c1ace83f3 > > Diff: https://reviews.apache.org/r/43177/diff/ > > > Testing > ------- > > Created a simple framework that launchs a task with a hdfs:// uri > > - Without this patch: fetcher failed with traceback like reported in jira > - With this patch: fetcher succeeds and the task is running > > > Thanks, > > Shuai Lin > >