> On Feb. 4, 2016, 7:09 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 751-752 > > <https://reviews.apache.org/r/43177/diff/1/?file=1232092#file1232092line751> > > > > Perhaps you should augment this comment with something like: > > ``` > > The libprocess port is explicitly removed because this will conflict > > with the already-running agent. > > ```
Done. - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43177/#review117856 ----------------------------------------------------------- On Feb. 4, 2016, 7:14 p.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43177/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 7:14 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4585 > https://issues.apache.org/jira/browse/MESOS-4585 > > > Repository: mesos > > > Description > ------- > > Erased libprocess related env vars for mesos-fetcher. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > dbf968df4b219fbbafd59d5560492b7c1ace83f3 > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > e60defde41167df68e6d3f475452f0b0fe32892b > src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 > src/tests/oversubscription_tests.cpp > c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb > > Diff: https://reviews.apache.org/r/43177/diff/ > > > Testing > ------- > > Created a simple framework that launchs a task with a hdfs:// uri > > - Without this patch: fetcher failed with traceback like reported in jira > - With this patch: fetcher succeeds and the task is running > > > Thanks, > > Shuai Lin > >