----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43240/ -----------------------------------------------------------
(Updated Feb. 5, 2016, 6:41 p.m.) Review request for mesos and Jie Yu. Changes ------- Addressed review comments. Repository: mesos Description (updated) ------- Whether `char` is signed or not is up to the implementation, so be more explicit here. Also, since we want a `char` with all bits set, use a value representation that more clearly communicates that. Diffs (updated) ----- src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339 Diff: https://reviews.apache.org/r/43240/diff/ Testing ------- When compiling with trunk clang, compilation fails with ../../src/log/tool/benchmark.cpp|209 col 47 warning| implicit conversion from 'int' to 'value_type' (aka 'char') changes value from 255 to -1 [-Wconstant-conversion] After inserting the explicit cast the code compiles fine. Thanks, Benjamin Bannier
