> On Feb. 5, 2016, 6:31 p.m., Jie Yu wrote:
> > src/log/tool/benchmark.cpp, line 209
> > <https://reviews.apache.org/r/43240/diff/1/?file=1235823#file1235823line209>
> >
> >     can you use 0xff here?

Yes, I can and should.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43240/#review118035
-----------------------------------------------------------


On Feb. 5, 2016, 6:41 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43240/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2016, 6:41 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Whether `char` is signed or not is up to the implementation, so be more 
> explicit
> here. Also, since we want a `char` with all bits set, use a value 
> representation
> that more clearly communicates that.
> 
> 
> Diffs
> -----
> 
>   src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339 
> 
> Diff: https://reviews.apache.org/r/43240/diff/
> 
> 
> Testing
> -------
> 
> When compiling with trunk clang, compilation fails with
> 
>     ../../src/log/tool/benchmark.cpp|209 col 47 warning| implicit conversion 
> from 'int' to 'value_type' (aka 'char') changes value from 255 to -1 
> [-Wconstant-conversion]
>     
> After inserting the explicit cast the code compiles fine.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to