----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review118233 -----------------------------------------------------------
Fix it, then Ship it! Thanks a bunch James, this looks great considering the complexity ;). Just some (debatable) nits I will fix while landing this. Makefile.am (lines 98 - 100) <https://reviews.apache.org/r/40553/#comment179456> Backslash alignment. src/Makefile.am (lines 1883 - 1884) <https://reviews.apache.org/r/40553/#comment179448> Let's make the backslashes align. src/Makefile.am (lines 1986 - 1994) <https://reviews.apache.org/r/40553/#comment179449> Backslash alignment. src/tests/containerizer/memory_test_helper.cpp <https://reviews.apache.org/r/40553/#comment179457> This should remain. src/tests/utils.hpp (line 65) <https://reviews.apache.org/r/40553/#comment179452> For consistency, let's add a short comment here as well. - Till Toenshoff On Feb. 4, 2016, 6:14 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40553/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 6:14 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-3608 > https://issues.apache.org/jira/browse/MESOS-3608 > > > Repository: mesos > > > Description > ------- > > This patch enables the installation mesos-tests and its dependencies > and helper tool. The goal is to allow operators to build a separate > test package that can be run at deployment time to verify that Mesos > works in the deployment environment. > > Since the build directory is searched first, to run it on a host > that has a build tree, you need to specify a non-existent tree: > > ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none > > - Add --enable-tests-install > - Fix mesos-tests gmock dependencies > - Optionally install tests, helpers and test modules > - Add utility helpers to find various test resources > > > Diffs > ----- > > Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e > configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 > src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 > src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab > src/tests/balloon_framework_test.sh > 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 > src/tests/containerizer/launch_tests.cpp > c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 > src/tests/containerizer/memory_test_helper.cpp > 4a3de2e3c887aa6afc604588850e1386f92d8c11 > src/tests/containerizer/mesos_containerizer_tests.cpp > a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 > src/tests/containerizer/ns_tests.cpp > 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b > src/tests/containerizer/port_mapping_tests.cpp > fd6f063bc5dc3761368742851e6853547c602e3b > src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 > src/tests/event_call_framework_test.sh > 9d1211552734afbf15b376f8c4629bae8a2065af > src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c > src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c > src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e > src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e > src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 > src/tests/no_executor_framework_test.sh > aebdc8c380abb2d041d6fc74dfac5a111c15267e > src/tests/oversubscription_tests.cpp > c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb > src/tests/persistent_volume_framework_test.sh > 84f02847a8d89400512d8a5714d33fb29cf5b03a > src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 > src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 > src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 > src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa > src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 > > Diff: https://reviews.apache.org/r/40553/diff/ > > > Testing > ------- > > > Thanks, > > James Peach > >