-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
-----------------------------------------------------------




src/linux/perf.cpp (lines 423 - 426)
<https://reviews.apache.org/r/43283/#comment179540>

    Hmmm, I'm not satisfied with this. I thought the new output format was 
introduced at a specific kernel version (3.13.0 might not be correct). Could 
you please confirm that the 3.10 on CentOS7.1 has the new unit field but other 
3.10 kernels don't.


- Ian Downes


On Feb. 7, 2016, 12:18 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2016, 12:18 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4039
>     https://issues.apache.org/jira/browse/MESOS-4039
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> -------
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to